AaronBallman wrote: > 1 nit on the release note, else this LGTM. > > We still need to let Aaron decide how long we are going to give WG21 a chance > to change this :)
CC @hubert-reinterpretcast for other opinions. My reading of the CWG thread is that Core seems to think this should be rejected, though I'm surprised that they'd like to limit the utility of attributes that way. We already have existing attributes that form invalid tokens which are used in the wild, like `availability` accepting a version number like `1.2.3`. `#` doesn't mean "preprocessor" within an attribute argument list the same as how `.` doesn't mean floating-point number or member access operator. For example, maybe someone wants an attribute that maps to GitHub issue or PR numbers, like `[[github(issues: #123, #456, pulls: #12)]]` or HTML color codes like `[[color(#ea64f9)]]`, etc. https://github.com/llvm/llvm-project/pull/147308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
