================
@@ -173,24 +173,78 @@ bool isLegalValidatorVersion(StringRef ValVersionStr,
const Driver &D) {
return true;
}
+std::string getSpirvExtOperand(llvm::StringRef SpvExtensionArg) {
----------------
llvm-beanz wrote:
nit: I would probably change this to take a `raw_ostream&` to write the operand
into, then you could use a SmallString with a big stack allocation, and reduce
the likelihood of lots of string re-allocations.
Feel free to take or leave this feedback as the driver isn't generally a
performance sensitive part of the compiler since we'll do this like once per
compile.
https://github.com/llvm/llvm-project/pull/151554
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
