https://github.com/HighCommander4 requested changes to this pull request.
I do think it would be good to have a test case for this; this is tricky code (and probably also performance-sensitive), and walking through a test case helps to think through the resulting behaviour. You can have a look at [this test case](https://searchfox.org/llvm/rev/b16fe132c68834a601b29c0eb53c7ec25a3cd627/clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp#312) as an example of a test for this class, which sets up a compilation database using the contents of `compile_commands.json` as input, and triggers operatins like `getCompileCommand()` on it. https://github.com/llvm/llvm-project/pull/148019 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
