================
@@ -7941,6 +7942,32 @@ static bool handleFunctionTypeAttr(TypeProcessingState 
&state, ParsedAttr &attr,
     return true;
   }
 
+  if (attr.getKind() == ParsedAttr::AT_CFISalt) {
+    if (attr.getNumArgs() == 0)
----------------
erichkeane wrote:

AS written, you're assuming an attribute can get to this point with `0` 
arguments.  I'm saying: IF that is ACTUALLY possible, you need to diagnose.  
SINCE it isn't (I'm quite sure!), this is a dead branch, and thus should be an 
assert, since it is something you're assuming.

https://github.com/llvm/llvm-project/pull/141846
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to