tarunprabhu wrote:

> > > What do you think is the right place in pass pipeline?
> > I don't know, but just a gut feeling, somewhere in 
> > `buildModuleOptimizationPipeline` looks reasonable to me rather than 
> > `buildFunctionSimplificationPipeline`. 
> Yeah, I don't have enough data to support the right place in the pipeline.

In that case. it may be better to move it to `buildModuleOptimizationPipeline`. 
This is undoubtedly an optimization, and a non-trivial one at that. There are 
still open questions about the exact placement of the pass within the 
optimization pipeline, but moving it into that function, with a (perhaps 
slightly tweaked) `FIXME` comment is probably better than leaving it in 
`buildFunctionSimplificationPipeline`.



https://github.com/llvm/llvm-project/pull/142686
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to