llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) <details> <summary>Changes</summary> Static analysis complained that: child_range(&Init, &Init+1); in the children member function was potentially out of bounds. This is false b/c it is forming an iterator range but it would be invalid if Init was a nullptr. I add an assertion in the constructor for this and remove to FIXME checks that are related to this. I checked the various usages and we always valid the argument is not nullptr. --- Full diff: https://github.com/llvm/llvm-project/pull/152593.diff 1 Files Affected: - (modified) clang/include/clang/AST/Expr.h (+1-6) ``````````diff diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h index 237b3b2cf7444..a5116a72264b9 100644 --- a/clang/include/clang/AST/Expr.h +++ b/clang/include/clang/AST/Expr.h @@ -3548,6 +3548,7 @@ class CompoundLiteralExpr : public Expr { QualType T, ExprValueKind VK, Expr *init, bool fileScope) : Expr(CompoundLiteralExprClass, T, VK, OK_Ordinary), LParenLoc(lparenloc), TInfoAndScope(tinfo, fileScope), Init(init) { + assert(Init && "Init is a nullptr"); setDependence(computeDependence(this)); } @@ -3577,17 +3578,11 @@ class CompoundLiteralExpr : public Expr { APValue &getStaticValue() const; SourceLocation getBeginLoc() const LLVM_READONLY { - // FIXME: Init should never be null. - if (!Init) - return SourceLocation(); if (LParenLoc.isInvalid()) return Init->getBeginLoc(); return LParenLoc; } SourceLocation getEndLoc() const LLVM_READONLY { - // FIXME: Init should never be null. - if (!Init) - return SourceLocation(); return Init->getEndLoc(); } `````````` </details> https://github.com/llvm/llvm-project/pull/152593 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
