[clang-tools-extra] Update debug output string (PR #152671)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clangd

Author: Mythreya Kuricheti (MythreyaK)

<details>
<summary>Changes</summary>

Include `Signature` and `SnippetSuffix` in the output, when test fails


Before: &lt;pre&gt;&lt;code&gt;Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, 
int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
  Actual: {  bar - 
{"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":"
 bar","labelDetails":{"detail":"(int 
arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10}}}}
 }, whose element #<!-- -->0 doesn't match
&lt;/code&gt;&lt;/pre&gt;

After: &lt;pre&gt;&lt;code&gt;Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, 
int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
  Actual: { &lt;mark&gt;Signature: "(A self, int arg)", SnippetSuffix: "", 
Rendered:&lt;/mark&gt; bar - 
{"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":"
 bar","labelDetails":{"detail":"(A self, int 
arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10}}}}
 }, whose element #<!-- -->0 doesn't match
&lt;/code&gt;&lt;/pre&gt;

---
Full diff: https://github.com/llvm/llvm-project/pull/152671.diff


1 Files Affected:

- (modified) clang-tools-extra/clangd/CodeComplete.cpp (+3) 


``````````diff
diff --git a/clang-tools-extra/clangd/CodeComplete.cpp 
b/clang-tools-extra/clangd/CodeComplete.cpp
index 9c17b4ca9b706..cacff21e155a7 100644
--- a/clang-tools-extra/clangd/CodeComplete.cpp
+++ b/clang-tools-extra/clangd/CodeComplete.cpp
@@ -2434,6 +2434,9 @@ CompletionItem CodeCompletion::render(const 
CodeCompleteOptions &Opts) const {
 }
 
 llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const CodeCompletion &C) {
+  OS << "Signature: " << "\"" << C.Signature << "\", "
+     << "SnippetSuffix: " << "\"" << C.SnippetSuffix << "\""
+     << ", Rendered:";
   // For now just lean on CompletionItem.
   return OS << C.render(CodeCompleteOptions());
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/152671
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits