llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) <details> <summary>Changes</summary> Addresses https://github.com/llvm/llvm-project/pull/83027#discussion_r2264102109 We can only reach this part by a non-null `Ptr`, which also implies a dereference of `PtrExpr`. Consequently, `PtrExpr` cannot be null here so the check is pointless. --- Full diff: https://github.com/llvm/llvm-project/pull/152850.diff 1 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp (+1-2) ``````````diff diff --git a/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp index da2d16ca9b5dd..3151f504d557f 100644 --- a/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp @@ -124,8 +124,7 @@ ProgramStateRef UnixAPIMisuseChecker::EnsurePtrNotNull( auto R = std::make_unique<PathSensitiveBugReport>( BT.value_or(std::cref(BT_ArgumentNull)), (PtrDescr + " pointer might be NULL.").str(), N); - if (PtrExpr) - bugreporter::trackExpressionValue(N, PtrExpr, *R); + bugreporter::trackExpressionValue(N, PtrExpr, *R); C.emitReport(std::move(R)); } return nullptr; `````````` </details> https://github.com/llvm/llvm-project/pull/152850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
