https://github.com/JonChesterfield requested changes to this pull request.

Request using intrinsics to represent this, not magic global variables, on the 
grounds that the magic globals hack should not have been done in the first 
place and definitely didn't need to live for a decade in rocm device libs.

Given how long it has existed there, I do not have confidence it would be fixed 
after commit in upstream. Further, I think someone else fixing it upstream 
would be opposed by the rocm developers on grounds of divergence from their 
fork.

https://github.com/llvm/llvm-project/pull/134016
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to