rorth wrote:

I've done a `Debug` build on `amd64-pc-solaris2.11` and found what's going on.  
When the `InterpreterTestBase.SanityWithRemoteExecution` test calls 
`getOrcRuntimePath`, it returns a value that is completely wrong: 
`/var/llvm/local-amd64-debug-gcc15/lib/clang/22/lib/x86_64-unknown-linux-gnu/liborc_rt.a`.

This is as wrong as possible:
- The target triple is hardcoded as `x86_64-unknown-linux-gnu` instead of the 
native triple.  That library simply doesn't exist except on Linux/x86_64.
- The code assumes the `runtimes` layout for target libs, while Solaris (like 
several other targets) uses the old `projects` layout.  In the case at hand, 
the library lives in 
`/var/llvm/local-amd64-debug-gcc15/lib/clang/22/lib/sunos/lib/liborc_rt-x86_64.a`.

I wonder how this test can ever have worked on any target but Linux/x86_64 (and 
macOS).  The fact that the test doesn't fail on `sparcv9-sun-solaris2.11` is 
simply due to the fact that SPARC has no JIT support.

Please either remove the test or fix this ASAP: the builder has been red for 3 
days now.

https://github.com/llvm/llvm-project/pull/152562
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to