klimek added a comment.

In https://reviews.llvm.org/D32480#773807, @Typz wrote:

> So how do I proceed?
>
> 1. Keep the CompactNamespace option, and make "compacted" namespaces always 
> add at most one level of indentation
> 2. Or assume that this can only ever usefully work with the behavior of 
> NI_None and add an additional enum value NI_Compact.


I'd vote for (1).

> And should we limit 'compacting' to namespace which start and end at 
> consecutive lines [e.g. exactly the same conditions as C++17 nested 
> namespaces], or is the current implementation enough [merge all adjacent 
> beginning and all adjacent endings] ?

I'd vote for the former.


https://reviews.llvm.org/D32480



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to