krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land.
================ Comment at: unittests/clangd/ClangdTests.cpp:432 + // size the same. + // We complete on the 3rd line(2nd in zero-based numbering), because raw + // string literal of the SourceContents starts with a newline(it's easy to ---------------- nit: add a space between `line` and `(`. ================ Comment at: unittests/clangd/ClangdTests.cpp:452 + StringRef(OverridenSourceContents)) + .Value; + EXPECT_TRUE(ContainsItem(CodeCompletionResultsOverriden, "cbc")); ---------------- Is this how clang-format formats this chain? :( https://reviews.llvm.org/D34107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
