[clang-tools-extra] [clang-tidy] Fix `cppcoreguidelines-prefer-member-initializer` false positive for inherited members (PR #153941)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tidy

Author: None (v1nh1shungry)

<details>
<summary>Changes</summary>

```cpp
struct Base {
  int m;
};

template &lt;class T&gt;
struct Derived : Base {
  Derived() { m = 0; }
};
```

would previously generate the following output:

```
&lt;source&gt;:7:15: warning: 'm' should be initialized in a member initializer 
of the constructor [cppcoreguidelines-prefer-member-initializer]
    7 |   Derived() { m = 0; }
      |               ^~~~~~
      |             : m(0)
```

This patch fixes this false positive.

Note that before this patch the checker won't give false positive for

```cpp
struct Derived : Base {
  Derived() { m = 0; }
};
```

and the constructor's AST is

```
`-CXXConstructorDecl 0x557df03d1fb0 &lt;line:7:3, col:22&gt; col:3 Derived 
'void ()' implicit-inline
    |-CXXCtorInitializer 'Base'
    | `-CXXConstructExpr 0x557df03d2748 &lt;col:3&gt; 'Base' 'void () noexcept'
    `-CompoundStmt 0x557df03d2898 &lt;col:13, col:22&gt;
      `-BinaryOperator 0x557df03d2878 &lt;col:15, col:19&gt; 'int' lvalue '='
        |-MemberExpr 0x557df03d2828 &lt;col:15&gt; 'int' lvalue -&gt;m 
0x557df03d1c40
        | `-ImplicitCastExpr 0x557df03d2808 &lt;col:15&gt; 'Base *' 
&lt;UncheckedDerivedToBase (Base)&gt;
        |   `-CXXThisExpr 0x557df03d27f8 &lt;col:15&gt; 'Derived *' implicit 
this
        `-IntegerLiteral 0x557df03d2858 &lt;col:19&gt; 'int' 0
```

so `isAssignmentToMemberOf` would return empty due to

https://github.com/llvm/llvm-project/blob/f0967fca04c880e9aabd5be043a85127faabb4c6/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp#L118-L119

---
Full diff: https://github.com/llvm/llvm-project/pull/153941.diff


3 Files Affected:

- (modified) 
clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp 
(+3) 
- (modified) clang-tools-extra/docs/ReleaseNotes.rst (+4) 
- (modified) 
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp
 (+17) 


``````````diff
diff --git 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
index 593a4f85d1309..79cd4bbcc9a60 100644
--- 
a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
+++ 
b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
@@ -191,6 +191,9 @@ void PreferMemberInitializerCheck::check(
     if (!AssignmentToMember)
       continue;
     const FieldDecl *Field = AssignmentToMember->Field;
+    // Skip if the field is inherited from a base class.
+    if (Field->getParent() != Class)
+      continue;
     const Expr *InitValue = AssignmentToMember->Init;
     updateAssignmentLevel(Field, InitValue, Ctor, AssignedFields);
     if (!canAdvanceAssignment(AssignedFields[Field]))
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst 
b/clang-tools-extra/docs/ReleaseNotes.rst
index 1553f461634d0..0d5dbd85df6a4 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -163,6 +163,10 @@ Changes in existing checks
   an additional matcher that generalizes the copy-and-swap idiom pattern
   detection.
 
+- Improved :doc:`cppcoreguidelines-prefer-member-initializer
+  <clang-tidy/checks/cppcoreguidelines/prefer-member-initializer>` check by
+  no longer giving false positives for inherited members.
+
 - Improved :doc:`misc-header-include-cycle
   <clang-tidy/checks/misc/header-include-cycle>` check performance.
 
diff --git 
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp
 
b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp
index 7d6164946fc3d..faff4882142f1 100644
--- 
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp
+++ 
b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp
@@ -650,3 +650,20 @@ struct InitFromBindingDecl {
   }
 };
 } // namespace GH82970
+
+namespace inherited_members {
+
+struct A {
+  int m;
+};
+
+struct B : A {
+  B() { m = 0; }
+};
+
+template <class T>
+struct C : A {
+  C() { m = 0; }
+};
+
+} // namespace inherited_members

``````````

</details>


https://github.com/llvm/llvm-project/pull/153941
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits