llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) <details> <summary>Changes</summary> If one of them is a one-past-end pointer. --- Full diff: https://github.com/llvm/llvm-project/pull/154342.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Pointer.cpp (+2) - (modified) clang/test/AST/ByteCode/unions.cpp (+10) ``````````diff diff --git a/clang/lib/AST/ByteCode/Pointer.cpp b/clang/lib/AST/ByteCode/Pointer.cpp index 7c6eb74da205c..89d9829399302 100644 --- a/clang/lib/AST/ByteCode/Pointer.cpp +++ b/clang/lib/AST/ByteCode/Pointer.cpp @@ -375,6 +375,8 @@ size_t Pointer::computeOffsetForComparison() const { } if (const Record *R = P.getBase().getRecord(); R && R->isUnion()) { + if (P.isOnePastEnd()) + ++Result; // Direct child of a union - all have offset 0. P = P.getBase(); continue; diff --git a/clang/test/AST/ByteCode/unions.cpp b/clang/test/AST/ByteCode/unions.cpp index 8ed76258b879a..f9bc05110acf9 100644 --- a/clang/test/AST/ByteCode/unions.cpp +++ b/clang/test/AST/ByteCode/unions.cpp @@ -966,3 +966,13 @@ namespace AddressComparison { static_assert(&U2.a[0] != &U2.b[1]); static_assert(&U2.a[0] == &U2.b[1]); // both-error {{failed}} } + +namespace UnionMemberOnePastEnd { + constexpr bool b() { + union { + int p; + }; + return &p == (&p + 1); + } + static_assert(!b()); +} `````````` </details> https://github.com/llvm/llvm-project/pull/154342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
