================ @@ -30,4 +30,5 @@ #include "clang/Basic/DiagnosticAnalysisKinds.inc" #include "clang/Basic/DiagnosticRefactoringKinds.inc" #include "clang/Basic/DiagnosticInstallAPIKinds.inc" +#include "clang/Basic/DiagnosticCodeGenKinds.inc" ---------------- delcypher wrote:
So the reason I picked the name `CodeGen` is because it seemed like the Diagnostics subsystem named the component after the library it was used in (e.g. `Analysis`, `InstallAPI`, `Sema`, etc...). An outlier to that I suppose would be the `Common` component. If you are ok with breaking (what looks like) convention then I'm happy with `DiagnosticTrapKinds` because it's a much better name. https://github.com/llvm/llvm-project/pull/154618 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
