rjmccall wrote: The only thing that "leaf type" means is that there's no point in doing anything except `dyn_cast`ing the canonical type. It's not a real language concept, and we don't use the type property for any purpose except these `getAs` specializations. So if the specializations are wrong for some types, either we should rip the concept out, or those types shouldn't be leaf types. In particular, I suspect that RecordType should no longer be a leaf type because of your changes to the representation of elaborated types.
The size of this PR is completely freaking Safari out. Can you make a PR that just adds `getAsRecordDecl()` and changes a bunch of call sites to use it? I assume that's like half the patch. https://github.com/llvm/llvm-project/pull/155028 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
