NagyDonat wrote:

Thanks for working on this :slightly_smiling_face: !

Is your code ready for a first round of review, or are you still planning 
significant changes?

By the way, please change the title of this PR to e.g. "Fix unique_ptr 
aggregate initialization false positives" or something similar that makes it 
somewhat recognizable. I see that it's difficult to give a short title to this 
particular change (and long titles should be avoided), but "Fix for false 
positive issue" is so generic that it would be suitable for at least a third of 
all analyzer commits.

https://github.com/llvm/llvm-project/pull/155131
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to