https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/155358
Checking CI with the RUN lines. They won't be pushed though because of a signed
integer overflow reported by ubsan that seems to happen on unsigned types.
>From 182c16a85d3a0d7961696fa5a2e387bf85a32e20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= <tbae...@redhat.com>
Date: Tue, 26 Aug 2025 07:56:46 +0200
Subject: [PATCH] [clang][bytecode] Support remaining add_sat like X86 builtins
Checking CI with the RUN lines. They won't be pushed though because
of a signed integer overflow reported by ubsan that seems to happen on
unsigned types.
---
clang/lib/AST/ByteCode/InterpBuiltin.cpp | 40 ++++++++++++++++++++++++
clang/test/CodeGen/X86/avx2-builtins.c | 8 +++++
2 files changed, 48 insertions(+)
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index e245f24e614e5..1aadf07ba5220 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -2557,6 +2557,8 @@ static bool interp__builtin_elementwise_sat(InterpState
&S, CodePtr OpPC,
const Pointer &LHS = S.Stk.pop<Pointer>();
const Pointer &Dst = S.Stk.peek<Pointer>();
PrimType ElemT = *S.getContext().classify(VT->getElementType());
+ bool DestUnsigned =
+ VT->getElementType()->isUnsignedIntegerOrEnumerationType();
unsigned NumElems = VT->getNumElements();
for (unsigned I = 0; I != NumElems; ++I) {
APSInt Elem1;
@@ -2590,6 +2592,34 @@ static bool interp__builtin_elementwise_sat(InterpState
&S, CodePtr OpPC,
Result = APSInt(llvm::APIntOps::mulhs(Elem1, Elem2),
/*isUnsigned=*/false);
break;
+ case clang::X86::BI__builtin_ia32_psllv2di:
+ case clang::X86::BI__builtin_ia32_psllv4di:
+ case clang::X86::BI__builtin_ia32_psllv4si:
+ case clang::X86::BI__builtin_ia32_psllv8si:
+ if (Elem2.uge(Elem2.getBitWidth())) {
+ Result = APSInt(APInt::getZero(Elem2.getBitWidth()), DestUnsigned);
+ break;
+ }
+ Result = APSInt(Elem1.shl(Elem2.getZExtValue()), DestUnsigned);
+ break;
+ case clang::X86::BI__builtin_ia32_psrav4si:
+ case clang::X86::BI__builtin_ia32_psrav8si:
+ if (Elem2.uge(Elem2.getBitWidth())) {
+ Result = APSInt(Elem1.ashr(Elem2.getBitWidth() - 1), DestUnsigned);
+ break;
+ }
+ Result = APSInt(Elem1.ashr(Elem2.getZExtValue()), DestUnsigned);
+ break;
+ case clang::X86::BI__builtin_ia32_psrlv2di:
+ case clang::X86::BI__builtin_ia32_psrlv4di:
+ case clang::X86::BI__builtin_ia32_psrlv4si:
+ case clang::X86::BI__builtin_ia32_psrlv8si:
+ if (Elem2.uge(Elem2.getBitWidth())) {
+ Result = APSInt(APInt::getZero(Elem2.getBitWidth()), DestUnsigned);
+ break;
+ }
+ Result = APSInt(Elem1.lshr(Elem2.getZExtValue()), DestUnsigned);
+ break;
default:
llvm_unreachable("Wrong builtin ID");
}
@@ -3236,6 +3266,16 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC,
const CallExpr *Call,
case clang::X86::BI__builtin_ia32_pmulhw128:
case clang::X86::BI__builtin_ia32_pmulhw256:
case clang::X86::BI__builtin_ia32_pmulhw512:
+ case clang::X86::BI__builtin_ia32_psllv2di:
+ case clang::X86::BI__builtin_ia32_psllv4di:
+ case clang::X86::BI__builtin_ia32_psllv4si:
+ case clang::X86::BI__builtin_ia32_psllv8si:
+ case clang::X86::BI__builtin_ia32_psrav4si:
+ case clang::X86::BI__builtin_ia32_psrav8si:
+ case clang::X86::BI__builtin_ia32_psrlv2di:
+ case clang::X86::BI__builtin_ia32_psrlv4di:
+ case clang::X86::BI__builtin_ia32_psrlv4si:
+ case clang::X86::BI__builtin_ia32_psrlv8si:
return interp__builtin_elementwise_sat(S, OpPC, Call, BuiltinID);
case Builtin::BI__builtin_elementwise_max:
diff --git a/clang/test/CodeGen/X86/avx2-builtins.c
b/clang/test/CodeGen/X86/avx2-builtins.c
index 29cb3e8860be9..49e35230ba225 100644
--- a/clang/test/CodeGen/X86/avx2-builtins.c
+++ b/clang/test/CodeGen/X86/avx2-builtins.c
@@ -7,6 +7,14 @@
// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -emit-llvm -o - -Wall -Werror |
FileCheck %s --check-prefixes=CHECK,X86
// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -fno-signed-char -emit-llvm -o
- -Wall -Werror | FileCheck %s --check-prefixes=CHECK,X86
+// RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s
-triple=x86_64-apple-darwin -target-feature +avx2 -emit-llvm -o - -Wall -Werror
-fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X64
+// RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s
-triple=x86_64-apple-darwin -target-feature +avx2 -fno-signed-char -emit-llvm
-o - -Wall -Werror -fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X64
+// RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -emit-llvm -o - -Wall -Werror
-fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X86
+// RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -fno-signed-char -emit-llvm -o
- -Wall -Werror -fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X86
+// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=x86_64-apple-darwin -target-feature +avx2 -emit-llvm -o - -Wall -Werror
-fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X64
+// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=x86_64-apple-darwin -target-feature +avx2 -fno-signed-char -emit-llvm
-o - -Wall -Werror -fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X64
+// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -emit-llvm -o - -Wall -Werror
-fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X86
+// RUN: %clang_cc1 -x c++ -flax-vector-conversions=none -ffreestanding %s
-triple=i386-apple-darwin -target-feature +avx2 -fno-signed-char -emit-llvm -o
- -Wall -Werror -fexperimental-new-constant-interpreter | FileCheck %s
--check-prefixes=CHECK,X86
#include <immintrin.h>
#include "builtin_test_helpers.h"
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
