================
@@ -203,19 +203,6 @@ template <> struct 
MappingTraits<FormatStyle::BraceWrappingFlags> {
   }
 };
 
-template <> struct ScalarEnumerationTraits<FormatStyle::BracketAlignmentStyle> 
{
----------------
HazardyKnusperkeks wrote:

I'd stick to the `bool` for the public API, and keep the `enum` only in the 
private part, i.e. `format.cpp` and parse the `enum` with all 6 possible 
values. And initialize from that the real options. For the output use the 
`bool`.

That way everything is handled, but the option stands out in parsing and 
testing of that.

The assert would be a bad idea, because it wouldn't break the users of 
`libFormat` at compile time, but the users of their software at runtime.

https://github.com/llvm/llvm-project/pull/108332
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to