ddpagan wrote: @chandraghale - Hi Chandra. Not sure if you are aware of the following, so I thought I would pass it along for future reference.
Per discussions in the OpenMP in LLVM biweekly meeting, it was decided that the OpenMPSupport.rst file should be kept up to date with information noting which OpenMP features are unclaimed, in progress, partially done, or done. This has been the case now for a few months, so when looking to work on a new feature, this file should be consulted first to ensure work is not duplicated. This feature (default clause on target) was already marked as "In Progress" in the OpenMPSupport.rst file, which indicates that someone is either preparing to work on, or already working on, this feature. In this particular case, I had already started some work on this feature. Your changes look fine to me as well, but Shilei's comment on the test should be addressed. I'll contact you directly so we can determine the status of any other related work done so far (beyond just enabling the clause). https://github.com/llvm/llvm-project/pull/154942 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
