mtrofin wrote: > > lgtm, just please remove the unrelated fix in MLInlineAdvisor (the > > follow-up PR, if you want to do it, doesn't need anything stuffy - just > > label the title as "[NFC]" - because it's not changing any behavior - and > > just say something as simple as "made a member static in MLInlineAdvisor" > > or something like that. > > Reverted making `CallBase *getInlinableCS(Instruction &I)` static on > MLInlineAdvisor. > > Removed from web viewer though seems it marks a change for some reason though > style check is not saying anything. Would I need to clang-format it anyway?
Looks fine now. https://github.com/llvm/llvm-project/pull/154541 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
