abhinavgaba wrote: > better to split the patch by the supported types or other criteria
That's going to be a bit complicated. Trying to break the change based on functional components was leaving clang in a bad intermediate state. That's why #145454 was pulled into the main PR #153683. Similarly, use_device_ptr/addr handling was breaking because of the previous code tightly coupled with the previous mapping scheme, so those had to be fixed as part of the same change. FWIW, the biggest portion of the changes in #145454 is from LIT test changes. I'll try to add more comments to the PR to link to various tests that are relevant to the code in each code-path etc. The standalone end-to-end tests were merged via different PRs, and most of the executable tests are just removing XFAILs, or doing minor updates to the CHECKs to remove the distinction between the expected/current output. https://github.com/llvm/llvm-project/pull/155625 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
