sarnex wrote: @Naghasan Thanks for the review!
> It seems strange to have different address spaces for 32/64. I understand you > probably don't care about 32, but it is tested. Right, I just wanted to minimize my change. Happy to add support for 32 if you think we should match, however the code will be a bit duplicated. > why mapping to generic ? This would conflict with > https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_function_pointers.asciidoc > if you want a proper implementation. Thanks for the spec! I didn't know the extension added a new storage class for function pointers. Let me try making it `9` for CodeSectionINTEL https://github.com/llvm/llvm-project/pull/135251 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
