keinflue wrote:

> Thanks, I think this looks pretty good.

Thank you.

Do you have any insights on my two comments?

> As a side effect this also applies these range attributes to types with 
> boolean representation which are not represented as i1 in parameters (if 
> these exist).

> AssumeBooleanRepresentation is used here because of || 
> NSAPI(CGM.getContext()).isObjCBOOLType(Ty) in IsBool above. This condition 
> was not present in the use of getRangeForType for load optimization purposes 
> and I do not know why it is special cased like this for the sanitizer.

https://github.com/llvm/llvm-project/pull/154807
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to