Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <burhan.sog...@gmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/157...@github.com>
AmrDeveloper wrote: > LGTM. in the case of the `Lowering/` folder I didn’t ask you to change those > since they go directly to LLVM IR, but if you want you can use > --check-prefix=LLVM for that folder. And for example in > spelling-locations.cpp, I don’t think we need to compare those to LLVM IR. > @AmrDeveloper what do you think? I think for lowering/ and other tests that will not require other changes we can keep them now, if later we need to update them to test IR then we can modify them https://github.com/llvm/llvm-project/pull/157333 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
