https://github.com/bcardosolopes approved this pull request.

LGTM

> I wonder whether we should immediately flatten multidimensional arrays in CIR 
> instead of casting pointers. Do we need this information for something?

Sounds like we might lose some of the type information flow here, however it's 
possible we might still have all info needed to reconstruct without too much 
work if needed, how much work does it actually simplify in lowering prepare 
though? Looks like we can evaluate this in a follow up PR?

https://github.com/llvm/llvm-project/pull/159820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to