https://github.com/anchuraj commented:
Hi @abidh , Thank you for the change. LGTM except the default visibility change. However, merging this change alone would mean flang would be accepting this option without any indication that it is not handled. It would be nice if - In Flang.cpp, you can throw a warning that it is not handled before merging this change. - Move the codegen opts changes (CompilerInvocation and CodeGenOpt) to the lowering changes in future so they get tested when the lowering change is added https://github.com/llvm/llvm-project/pull/158314 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
