https://github.com/andykaylor commented:

This is an awful lot of code, and a lot of it isn't covered by the test. Is it 
possible to strip this down to just the paths that are needed by the test and 
replace the rest with NYI markers?

Also, throughout this PR there are a lot of places where our usual naming 
conventions aren't being followed, auto is overused, and llvm_unreachable is 
used where errorNYI should be. I marker some of them, but not all.



https://github.com/llvm/llvm-project/pull/160002
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to