https://github.com/steakhal requested changes to this pull request.
I agree that CallEvents have this trap. I've seen it. I don't think it's too widespread. I think we usually catch the use of stale states of CallEvents during review. It also helps that the State is part of our vocabulary and its passed liberally as a parameter, which sets a good example. This is a critical piece of code. Many of the changed lines look aesthetic, aka. refactor. You mention some bug if I recall my sloppy reading, but I could not spot behavioral changes or at least it didn't stand out to me. If this is NFC, let's adjust the PR title. If has behavioral change, let's have a test exposing that and split off the refactor parts. https://github.com/llvm/llvm-project/pull/160707 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
