gtbercea marked an inline comment as done.
gtbercea added inline comments.

================
Comment at: lib/Driver/ToolChains/Cuda.cpp:435
+
+    // TODO: get the compute capability from offloading arguments when not
+    // using the default compute capability of sm_20.
----------------
hfinkel wrote:
> gtbercea wrote:
> > hfinkel wrote:
> > > Why is this a TODO? Is the necessary information not currently available 
> > > in the offloading arguments, or are we just not grabbing it in this patch?
> > > 
> > This is for a future patch in which we will grab the compute capability 
> > from a special flag. I believe there has already been some discussion on 
> > the dev mailing list as to what that flag should be but I don't think there 
> > was a general consensus as to how that flag should be named.
> Which mailing list thread discussed this?
I believe it was openmp-dev. The proposal was initially posted by Gregory 
Rodgers.


Repository:
  rL LLVM

https://reviews.llvm.org/D29647



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to