Author: rnk Date: Fri Jun 30 09:11:49 2017 New Revision: 306835 URL: http://llvm.org/viewvc/llvm-project?rev=306835&view=rev Log: Revert "[CodeGen] Propagate dllexport to thunks"
This reverts r306770, it causes LNK4102 warnings in MSVC builds. Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/test/CodeGenCXX/windows-itanium-dllexport.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGVTables.cpp?rev=306835&r1=306834&r2=306835&view=diff ============================================================================== --- cfe/trunk/lib/CodeGen/CGVTables.cpp (original) +++ cfe/trunk/lib/CodeGen/CGVTables.cpp Fri Jun 30 09:11:49 2017 @@ -64,10 +64,6 @@ static void setThunkProperties(CodeGenMo const CXXMethodDecl *MD = cast<CXXMethodDecl>(GD.getDecl()); setThunkVisibility(CGM, MD, Thunk, ThunkFn); - // Propagate dllexport storage. - if (MD->hasAttr<DLLExportAttr>()) - ThunkFn->setDLLStorageClass(llvm::GlobalValue::DLLExportStorageClass); - if (CGM.supportsCOMDAT() && ThunkFn->isWeakForLinker()) ThunkFn->setComdat(CGM.getModule().getOrInsertComdat(ThunkFn->getName())); } Modified: cfe/trunk/test/CodeGenCXX/windows-itanium-dllexport.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/windows-itanium-dllexport.cpp?rev=306835&r1=306834&r2=306835&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/windows-itanium-dllexport.cpp (original) +++ cfe/trunk/test/CodeGenCXX/windows-itanium-dllexport.cpp Fri Jun 30 09:11:49 2017 @@ -53,12 +53,3 @@ USEMEMFUNC(outer<char>::inner, f) // CHECK: declare dllimport {{.*}} @_ZN5outerIcE1fEv // CHECK: define {{.*}} @_ZN5outerIcE5inner1fEv - -struct base { - virtual ~base(); -}; -struct __declspec(dllexport) derived : public virtual base { - virtual ~derived() {} -}; - -// CHECK: define {{.*}} dllexport {{.*}} @_ZTv0_n12_N7derivedD0Ev _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits