================
@@ -90,6 +90,7 @@ void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) {
   Finder->addMatcher(
       cxxCatchStmt(unless(isExpansionInSystemHeader()), unless(isInMacro()),
                    unless(hasCaughtType(IgnoredExceptionType)),
+                   unless(hasAncestor(cxxDestructorDecl())),
----------------
5chmidti wrote:

This could lead to an empty catch block defined in lambdas to be ignored. What 
needs to be matched instead, is that the functionDecl one up is the destructor 
(which sadly complicated the matcher). I can't easily check on mobile, but was 
there an enclosing function matcher, maybe in utils?

https://github.com/llvm/llvm-project/pull/161379
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to