AmrDeveloper wrote: > I think this lacks testing, another approach would be to diminish the PR by > removing code for all paths not triggered by current testcase.
I think most code in this PR is for the skeleton itself, and using TryOp, not sure if there is any part that I can remove and keep the test passed. The parts that can be removed are the Attributes and their parsers/printers, but I think now they are already tested 🤔. If needed, I can error out and move them to another PR What do you think? @bcardosolopes https://github.com/llvm/llvm-project/pull/162528 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
