arphaman added inline comments.

================
Comment at: lib/Sema/SemaExpr.cpp:142
   if (Result == AR_NotYetIntroduced) {
+    if (AvoidAvailabilityChecks)
+      return;
----------------
erik.pilkington wrote:
> arphaman wrote:
> > erik.pilkington wrote:
> > > Why are we doing this just for partials? Doesn't this also apply to 
> > > unavailable/deprecated?
> > We warned about the unavailable/deprecated protocols previously, so we 
> > should probably keep these warnings. The unguarded availability one is new, 
> > so we can drop it.
> But this is strictly less diagnostics, dropping diagnostics for unavail/depr 
> here won't break anything outside of clang tests. So if they don't make sense 
> to emit, then there isn't any reason to keep them around.
Swift emits warnings about deprecated/unavailable protocols even in the list of 
protocol requirements. I'd prefer it if we had the same behaviour.


Repository:
  rL LLVM

https://reviews.llvm.org/D35061



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to