hubert-reinterpretcast wrote: > Looks like @hubert-reinterpretcast should make another pass at review/tell us > when he thinks this is ready/good.
There are already outstanding comments for the author to address. https://github.com/llvm/llvm-project/pull/158048#pullrequestreview-3236886909 provides a case that does not match the design summarized in https://github.com/llvm/llvm-project/pull/158048#issuecomment-3313760151. Additionally, the design we arrived at requires a larger test matrix than what we have coverage for under the current state of the PR. https://github.com/llvm/llvm-project/pull/158048 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
