================
@@ -315,6 +315,19 @@ class AnnotatedLine;
 
 /// A wrapper around a \c Token storing information about the
 /// whitespace characters preceding it.
+
+// Describes the kind of a block comment.
+enum class CommentKind {
+  // A plain comment, i.e. /* ... */.
+  Plain,
+  // A comment that starts with /*! or /**.
+  Docstring,
+  // A comment that looks like a parameter, e.g. /*in*/.
+  Parameter,
+  // A comment that is a sentinel, e.g. /*FALLTHROUGH*/.
+  Sentinel,
----------------
HazardyKnusperkeks wrote:

Do you have a style guide which suggest adding spaces into comments, but 
doesn't for the potential `Sentinel`s? I personally wouldn't enable this 
option, so no real input from me, but I'd guess someone who wants spaces inside 
the comments can also live with `/* FALLTHROUGH */`. Most of those comments 
I've seen are also in lower case and sometimes with `fall-through` or `fall 
through`, which may open endless possibilities to support, if we support one. 
So I'd say we don't need that, the comments on the other hand as suggested by 
@mydeveloperday are common practice in many code bases (e.g. LLVM).

https://github.com/llvm/llvm-project/pull/162105
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to