AaronBallman wrote: > Hmm, I candidly don’t think just renaming a bunch of variables is a good > change, especially if the existing ones already adhere to our naming > convention, even if the names are a bit odd... we normally avoid changes that > are essentially purely formatting and this seems to be an example of that. > > CC @AaronBallman for opinions
Yeah, it's kind of on the edge of what we'd usually take. The problem isn't "we don't like having nice things like reasonable names", it's that we have a lot of downstreams and any time we make sweeping changes those downstreams run the risk of hitting merge conflicts when pulling the latest changes from upstream. So we try to make sure that those potential merge conflicts are worth the pain. In this case, I think the changes are worth it because the work was already done, the names are a strict improvement over what we have, and the PR is already posted with folks looking at it. That said, I wouldn't recommend making new PRs along these same lines unless you were planning on making other changes to the same code and the renames were in service of that other work. https://github.com/llvm/llvm-project/pull/166082 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
