github-actions[bot] wrote:
<!--LLVM CODE LINT COMMENT: clang-tidy-->
:warning: C/C++ code linter clang-tidy found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
```bash
git diff -U0 origin/main...HEAD --
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.h
clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
-path build -p1 -quiet
```
</details>
<details>
<summary>
View the output from clang-tidy here.
</summary>
```
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:17:6: warning:
function 'isInMacro' is declared in an anonymous namespace; prefer using
'static' for restricting visibility
[llvm-prefer-static-over-anonymous-namespace]
17 | bool isInMacro(const SourceRange &R, const MatchFinder::MatchResult
&Res) {
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:21:17: warning:
function 'tokenRange' is declared in an anonymous namespace; prefer using
'static' for restricting visibility
[llvm-prefer-static-over-anonymous-namespace]
21 | CharSourceRange tokenRange(const SourceRange &R,
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:26:13: warning:
function 'getTokenText' is declared in an anonymous namespace; prefer using
'static' for restricting visibility
[llvm-prefer-static-over-anonymous-namespace]
26 | std::string getTokenText(const SourceRange &R,
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:33:13: warning:
function 'strip' is declared in an anonymous namespace; prefer using 'static'
for restricting visibility [llvm-prefer-static-over-anonymous-namespace]
33 | const Expr *strip(const Expr *E) { return E ? E->IgnoreParenImpCasts()
: E; }
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:36:13: warning:
function 'enclosingStmt' is declared in an anonymous namespace; prefer using
'static' for restricting visibility
[llvm-prefer-static-over-anonymous-namespace]
36 | const Stmt *enclosingStmt(const Expr *E, const MatchFinder::MatchResult
&Res) {
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:50:7: warning:
do not use 'else' after 'return' [llvm-else-after-return]
50 | } else {
| ^~~~~~
51 | return Cur;
| ~~~~~~~~~~~
52 | }
| ~
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.h:15:3: warning:
function 'clang::tidy::modernize::ConditionalToIfCheck::ConditionalToIfCheck'
has a definition with different parameter names
[readability-inconsistent-declaration-parameter-name]
15 | ConditionalToIfCheck(llvm::StringRef Name, ClangTidyContext *Context);
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.cpp:58:23: note:
the definition seen here
58 | ConditionalToIfCheck::ConditionalToIfCheck(StringRef Name,
| ^
clang-tools-extra/clang-tidy/modernize/ConditionalToIfCheck.h:15:3: note:
differing parameters are named here: ('Context'), in definition: ('Ctx')
15 | ConditionalToIfCheck(llvm::StringRef Name, ClangTidyContext *Context);
| ^ ~~~~~~~
| Ctx
```
</details>
https://github.com/llvm/llvm-project/pull/166822
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
