================
@@ -2313,10 +2313,8 @@ StmtResult Parser::ParseBreakOrContinueStatement(bool 
IsContinue) {
       // TODO: Make this a compatibility/extension warning instead once the
       // syntax of this feature is finalised.
       Diag(LabelLoc, diag::err_c2y_labeled_break_continue) << IsContinue;
-    if (!Target) {
+    if (!Target)
       Diag(LabelLoc, diag::err_break_continue_label_not_found) << IsContinue;
-      return StmtError();
----------------
Sirraide wrote:

I feel like the main issue here is the fact that we’re trying to 
constant-evaluate a function that contains an error... which is a bit 
questionable imo.

> we could break to the nearest loop as a way to recover, but that may end up 
> generating confusing false positives with CFG-based diagnostics

I don’t believe CFG-based diagnostics run if there was an error (at least the 
ones in the static analyser don’t)?


https://github.com/llvm/llvm-project/pull/168332
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to