mgcarrasco wrote:

> I like this in concept, but a few of these take it a bit too far in the other 
> direction, stuff like `IsAMDGPUOrHIP` isn't much more readable than `IsAMDGPU 
> || IsHIP`. Try to simplify this a bit more and possible pull in some 
> conditions from the previous and later lines

Thanks @jhuber6. I've updated the PR.

https://github.com/llvm/llvm-project/pull/164994
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to