https://github.com/llvm-beanz commented:

You've combined a refactoring of existing code with a functional change. It 
would be better if the refactoring were done in a separate NFC change that 
could be evaluated separately from the new functionality being added.

https://github.com/llvm/llvm-project/pull/167946
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to