erichkeane added a comment. In https://reviews.llvm.org/D35519#813082, @echristo wrote:
> If you wouldn't mind I'd like to see this separated out a bit - > a) I think we can make the attribute info a struct rather than a pair as a > simple change first > b) setCPU split > c) let's see where we are after that? > > Also the description makes it sound like you're adding support for the > feature rather than fixing the terrible error diagnostics - or at least to my > early morning brain. :) > > Also, one inline comment so far. > > Thanks! > > -eric Caught me just in time :) Sure, I can split this into a couple of patches. I'll abandon this one and go from there. https://reviews.llvm.org/D35519 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
