andykaylor wrote:

> Sounds good. Can I make the check in the NYI helper an assertion, so it 
> produces a different error message when a builtin is reached that should 
> generate a libcall?

Maybe just make it a different errorNYI message? It would also be nice to have 
a MissingFeatures assert on the lines where we break out of the switch because 
we know it's a libcall but we really want to handle the builtin some other way.

I just ran the llvm-test-suite single source tests with this patch, and it 
looks like the only two missing breaks are __builtin_memset and 
__builtin_isnan. There are likely others that just aren't covered in these 
tests, but we can deal with those as we find them.

https://github.com/llvm/llvm-project/pull/168699
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to