jroelofs added inline comments.
================
Comment at: cmake/caches/Android-stage2.cmake:37
+ set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE
BOOL "")
+ set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
+ set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_THREADS OFF CACHE BOOL "")
----------------
pirama wrote:
> Should we initialize it to LLVM_ENABLE_ASSERTIONS rather than defaulting to
> ON? So assertions can be enabled/disabled for all targets with just one
> switch (and then over-ride with per-target flags, if necessary).
No. Absolutely not. Whether or not the bits of the toolchain that run on the
host have assertions should be *completely* independent of whether the target
bits do or don't. Do not conflate the host with the target.
https://reviews.llvm.org/D33561
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
