[clang-tools-extra] [clang-tidy] Add misc-bool-bitwise-operation check (PR #167552)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions c,h,cpp -- 
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp 
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-change-possible-side-effect.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-flags.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-ignore-macros.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-nontraditional.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-not-only-bool-operand-compound.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-not-only-bool-operand.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-static-members.cpp
 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-struct-members.cpp
 clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation.c 
clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation.cpp 
clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp 
b/clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp
index fe3bac73b..4fe8460d0 100644
--- a/clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp
@@ -63,7 +63,8 @@ static bool isBooleanBitwise(const BinaryOperator *BinOp, 
ASTContext *AC,
   if (!BinOp)
     return false;
 
-  if (!llvm::is_contained(llvm::make_first_range(OperatorsTransformation), 
BinOp->getOpcodeStr()))
+  if (!llvm::is_contained(llvm::make_first_range(OperatorsTransformation),
+                          BinOp->getOpcodeStr()))
     return false;
 
   bool IsBooleanLHS = BinOp->getLHS()
@@ -91,16 +92,14 @@ static bool isBooleanBitwise(const BinaryOperator *BinOp, 
ASTContext *AC,
   }
 
   std::optional<bool> DummyFlag = false;
-  IsBooleanLHS =
-      IsBooleanLHS ||
-      isBooleanBitwise(
-          dyn_cast<BinaryOperator>(BinOp->getLHS()->IgnoreParenImpCasts()),
-          AC, DummyFlag);
-  IsBooleanRHS =
-      IsBooleanRHS ||
-      isBooleanBitwise(
-          dyn_cast<BinaryOperator>(BinOp->getRHS()->IgnoreParenImpCasts()),
-          AC, DummyFlag);
+  IsBooleanLHS = IsBooleanLHS ||
+                 isBooleanBitwise(dyn_cast<BinaryOperator>(
+                                      BinOp->getLHS()->IgnoreParenImpCasts()),
+                                  AC, DummyFlag);
+  IsBooleanRHS = IsBooleanRHS ||
+                 isBooleanBitwise(dyn_cast<BinaryOperator>(
+                                      BinOp->getRHS()->IgnoreParenImpCasts()),
+                                  AC, DummyFlag);
 
   if (IsBooleanLHS && IsBooleanRHS) {
     RootAssignsToBoolean = RootAssignsToBoolean.value_or(false);

``````````

</details>


https://github.com/llvm/llvm-project/pull/167552
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits