================
@@ -34,82 +35,53 @@ class LintArgs:
     issue_number: int = 0
     build_path: str = "build"
     clang_tidy_binary: str = "clang-tidy"
+    doc8_binary: str = "doc8"
 
-    def __init__(self, args: argparse.Namespace = None) -> None:
+    def __init__(self, args: argparse.Namespace) -> None:
         if not args is None:
             self.start_rev = args.start_rev
             self.end_rev = args.end_rev
             self.repo = args.repo
             self.token = args.token
-            self.changed_files = args.changed_files
+            if args.changed_files:
+                self.changed_files = args.changed_files.split(",")
+            else:
+                self.changed_files = []
----------------
zeyi2 wrote:

> Is this needed? If empty `changed_files` are passed, then 
> `self.changed_files` would be empty anyway

It was added because previously `doc8` and `clang-tidy` used different ways to 
handle `changed_files`, this was meant to unify them. But you are correct, this 
is not necessary. Thanks!

https://github.com/llvm/llvm-project/pull/168827
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to