================
@@ -72,11 +72,25 @@ IntegerLiteralSeparatorFixer::process(const Environment
&Env,
if (SkipBinary && SkipDecimal && SkipHex)
return {};
- const auto BinaryMinDigits =
- std::max((int)Option.BinaryMinDigits, Binary + 1);
- const auto DecimalMinDigits =
- std::max((int)Option.DecimalMinDigits, Decimal + 1);
- const auto HexMinDigits = std::max((int)Option.HexMinDigits, Hex + 1);
+ auto CalcMinAndMax = [](int Digits, int MinDigitsInsert,
+ int MaxDigitsRemove) {
+ std::pair<int, int> Ret;
+ Ret.first = std::max(MinDigitsInsert, Digits + 1);
+ if (Ret.first == 0)
+ Ret.second = 0;
+ else if (MaxDigitsRemove <= 0)
+ Ret.second = Ret.first - 1;
+ else
+ Ret.second = std::min(MaxDigitsRemove, Ret.first - 1);
+ return Ret;
----------------
owenca wrote:
```suggestion
if (MinDigitsInsert <= DigitsPerGroup)
MinDigitsInsert = DigitsPerGroup + 1;
if (MinDigitsInsert < 1)
MaxDigitsRemove = 0;
else if (MaxDigitsRemove < 1 || MaxDigitsRemove >= MinDigitsInsert)
MaxDigitsRemove = MinDigitsInsert - 1;
return std::pair(MinDigitsInsert, MaxDigitsRemove);
```
https://github.com/llvm/llvm-project/pull/164286
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
