================ @@ -18,24 +18,27 @@ """ import argparse +import github +import json +from operator import attrgetter import os import subprocess import sys -from typing import List, Optional +from typing import Any, Dict, Final, List, Optional class LintArgs: - start_rev: str = None - end_rev: str = None - repo: str = None - changed_files: List[str] = [] - token: str = None + start_rev: Optional[str] = None ---------------- vbvictor wrote:
Can we assign strings to "" then? Semantically these values shouldn't be optional because they always must be provided as script input https://github.com/llvm/llvm-project/pull/168827 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
