================
@@ -18,98 +18,65 @@
"""
import argparse
+import github
+import json
import os
import subprocess
import sys
-from typing import List, Optional
+from typing import Any, Dict, Final, List, Sequence
class LintArgs:
- start_rev: str = None
- end_rev: str = None
- repo: str = None
- changed_files: List[str] = []
- token: str = None
+ start_rev: str
+ end_rev: str
+ repo: str
+ changed_files: Sequence[str]
+ token: str
verbose: bool = True
issue_number: int = 0
build_path: str = "build"
clang_tidy_binary: str = "clang-tidy"
- def __init__(self, args: argparse.Namespace = None) -> None:
+ def __init__(self, args: argparse.Namespace) -> None:
if not args is None:
self.start_rev = args.start_rev
self.end_rev = args.end_rev
self.repo = args.repo
self.token = args.token
- self.changed_files = args.changed_files
+ self.changed_files = (
+ args.changed_files.split(",") if args.changed_files else []
----------------
zeyi2 wrote:
In the original script at
[L301](https://github.com/llvm/llvm-project/blob/6459f39c377dc8b7d5d81ef365553c8625fb4def/llvm/utils/git/code-lint-helper.py#L301),
it was:
```
changed_files = []
if args.changed_files:
changed_files = args.changed_files.split(",")
```
I moved it here, it was basically the same logic.
https://github.com/llvm/llvm-project/pull/168827
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
