teresajohnson wrote: > > Also, please add a change to an existing memprof test like suggested above > > - this will ensure the phase ordering stays correct. > > Sorry, missed that. Added 2 new tests - it seems that we need > -supports-hot-cold-new and the index so the LTO pipeline doesn't remove the > hot/cold hints, correct? I added a dedicated test to the AllocToken suite and > another in the LTO/X86 suite, the latter of which should ensure we catch any > deeper regressions.
Ah, that is a complication, I should put that pass under an internal option so it could be disabled for testing, but what you did here lgtm. https://github.com/llvm/llvm-project/pull/169358 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
